Re: CREATE TABLE ( .. STORAGE ..) - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: CREATE TABLE ( .. STORAGE ..)
Date
Msg-id CAJ7c6TNntQrB2NsD7zWeFosNeJkqMtjX1th6peKGP0A+YR2bsQ@mail.gmail.com
Whole thread Raw
In response to Re: CREATE TABLE ( .. STORAGE ..)  (Matthias van de Meent <boekewurm+postgres@gmail.com>)
Responses Re: CREATE TABLE ( .. STORAGE ..)
List pgsql-hackers
Hi Matthias,

> Apart from this comment on the format of the patch, the result seems solid.

Many thanks.

> When updating a patchset generally we try to keep the patches
> self-contained, and update patches as opposed to adding incremental
> patches to the set.

My reasoning was to separate my changes from the ones originally
proposed by Teodor. After doing `git am` locally a reviewer can see
them separately, or together with `git diff origin/master`, whatever
he or she prefers. The committer can choose between committing two
patches ony by one, or rebasing them to a single commit.

I will avoid the "patch for the patch" practice from now on. Sorry for
the inconvenience.

-- 
Best regards,
Aleksander Alekseev



pgsql-hackers by date:

Previous
From: Justin Pryzby
Date:
Subject: Re: fix stats_fetch_consistency value in postgresql.conf.sample
Next
From: Sajti Zsolt Zoltán
Date:
Subject: Global variable/memory context for PostgreSQL functions