Re: Table AM and DROP TABLE [ Was: Table AM and DDLs] - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: Table AM and DROP TABLE [ Was: Table AM and DDLs]
Date
Msg-id CAJ7c6TNWBVy1RHV-m-Ugg8+8PRY2NvOGm-RBwNYP7Kn5Tkq9bA@mail.gmail.com
Whole thread Raw
In response to Table AM and DROP TABLE [ Was: Table AM and DDLs]  (Mats Kindahl <mats@timescale.com>)
Responses Re: Table AM and DROP TABLE [ Was: Table AM and DDLs]  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-hackers
Hi hackers,

> As a matter of fact, I think the patch I suggested is the right approach:
> let me elaborate on why.
> [...]
> It is straightforward to replace it by implementing the Table AM methods
> above, but we are missing a callback on dropping the table. If we have that,
> we can record the table-to-be-dropped in a similar manner to how the heap AM
> does it and register a transaction callback using RegisterXactCallback.

Since no one objected in 5 months, I assume Mats made a good point. At least,
personally, I can't argue.

The patch looks good to me except for the fact that comments seem to be
inaccurate in light of the discussion. The corrected patch is attached.
I'm going to mark it as "Ready for Committer" unless anyone objects.

-- 
Best regards,
Aleksander Alekseev

Attachment

pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: can we add some file(msvc) to gitignore
Next
From: Daniel Gustafsson
Date:
Subject: Re: [PATCH] Cross-reference comments on signal handling logic