Re: [PATCH] Cross-reference comments on signal handling logic - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: [PATCH] Cross-reference comments on signal handling logic
Date
Msg-id C6D35968-AA00-49C1-AEAC-B78AB02FCB24@yesql.se
Whole thread Raw
In response to [PATCH] Cross-reference comments on signal handling logic  (Craig Ringer <craig.ringer@enterprisedb.com>)
List pgsql-hackers
> On 1 Mar 2021, at 19:22, Mark Dilger <mark.dilger@enterprisedb.com> wrote:

>> On Jan 17, 2021, at 11:51 PM, Craig Ringer <craig.ringer@enterprisedb.com> wrote:
>>
>> <v1-0001-Comments-and-cross-references-for-signal-handling.patch>
>
> In src/backend/postmaster/interrupt.c:
>
> + * These handlers are NOT used by normal user backends as they do not support
>
> vs.
>
> + * Most backends use this handler.
>
> These two comments seem to contradict.  If interrupt.c contains handlers that normal user backends to not use, then
howcan it be that most backends use one of the handlers in the file? 

I'm closing this as Returned with Feedback as it there has been no response to
the review comment during two commitfests.  Please reopen in a future
commitfest if you still would like to pursue this patch.

--
Daniel Gustafsson        https://vmware.com/




pgsql-hackers by date:

Previous
From: Aleksander Alekseev
Date:
Subject: Re: Table AM and DROP TABLE [ Was: Table AM and DDLs]
Next
From: Alvaro Herrera
Date:
Subject: Re: Column Filtering in Logical Replication