Downloads
Home   >   mailing lists

Re: Avoid possible dereference null pointer (src/backend/utils/cache/relcache.c) - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: Avoid possible dereference null pointer (src/backend/utils/cache/relcache.c)
Date
Msg-id CAJ7c6TMpdhueA6RXr1PVhpqGF6YXBLe4M2hL97RFq88Osnza5g@mail.gmail.com
Whole thread Raw
In response to Avoid possible dereference null pointer (src/backend/utils/cache/relcache.c)  (Ranier Vilela <ranier.vf@gmail.com>)
Responses Re: Avoid possible dereference null pointer (src/backend/utils/cache/relcache.c)
List pgsql-hackers
Tree view 
Hi,

>> We would be in serious trouble if RelationReloadNailed() could be
>> called for a non-existing relation. Wouldn't Assert() be more
>> appropriate?
>
> IMO, I think no.
>
> In all paths, this check is done, why would this be the only exception?

We use Asserts() for cases that shouldn't happen in practice for
performance reasons. Since this code doesn't crash I suspect this is
one of such cases. Unless you are aware of a specific scenario that
makes the code crash of course.

-- 
Best regards,
Aleksander Alekseev

pgsql-hackers by date:

Previous
From: Aleksander Alekseev
Date:
Subject: Re: --enable-{debug,cassert} should also activate --enable-depend
Next
From: Andres Freund
Date:
Subject: Re: Non-reproducible AIO failure