Re: --enable-{debug,cassert} should also activate --enable-depend - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: --enable-{debug,cassert} should also activate --enable-depend
Date
Msg-id CAJ7c6TM-=ms1=NFk64hiKVyQcX2+ObDz3nSWjtcmc3DwxL2q3Q@mail.gmail.com
Whole thread Raw
Responses Re: --enable-{debug,cassert} should also activate --enable-depend
List pgsql-hackers
Hi Dimitris,

> I just spent 2 miserable days tracking down a very weird issue. I ended up
> stepping through the code in the debugger. As it turned out, the very same
> moment of execution, one datastructure (struct _restoreOptions defined in
> pg_backup.h) contained different fields on one data frame than another!
> This was the result of one object file *not* being re-compiled as needed,
> after applying my patch that added that extra field to the datastructure
> in pg_backup.h.
>
> This caused weird and completely irrelevant failures, as unexpected fields
> of the struct were changing value.
>
> I then found that I need to compile with --enable-depend to have Makefiles
> with proper dependency tracking. Shouldn't it be the default, at least for
> non-release builds?

I sympathize but realistically I doubt that someone is going to do
something about it. Autotools slowly approaches its end of life and
for Meson we don't seem to have an equivalent of --enable-depend. On
top of that I imagine how one could argue that these options should be
independent.

-- 
Best regards,
Aleksander Alekseev



pgsql-hackers by date:

Previous
From: jian he
Date:
Subject: Re: wrong comments in rewriteTargetListIU
Next
From: Aleksander Alekseev
Date:
Subject: Re: Avoid possible dereference null pointer (src/backend/utils/cache/relcache.c)