Re: Keep compiler silence (clang 10, implicit conversion from 'long'to 'double' ) - Mailing list pgsql-hackers

From Yuya Watari
Subject Re: Keep compiler silence (clang 10, implicit conversion from 'long'to 'double' )
Date
Msg-id CAJ2pMkY-dGz0Bc7xFaXqk7hk30KzrP6msZfHAHpJ-SnE_ZLD3w@mail.gmail.com
Whole thread Raw
In response to Re: Keep compiler silence (clang 10, implicit conversion from 'long' to 'double' )  (Andrew Gierth <andrew@tao11.riddles.org.uk>)
Responses Re: Keep compiler silence (clang 10, implicit conversion from'long' to 'double' )  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
List pgsql-hackers
Hello Tom, Thomas, and Andrew,

>  Tom> That commit presumes that floats follow the IEEE bitwise
>  Tom> representation, I think;
>
> Correct. (It notably does _not_ make any assumptions about how floating
> point arithmetic or comparisons work - all the computation is done in
> integers.)
>
>  Tom> but it's a long way from there to assuming that float comparisons
>  Tom> do something that is explicitly *not* promised by C99.
>
> I agree.

Thank you for your comments. I agree that we should not assume
anything that is not guaranteed in the language specification. The
modified patch (attached in the previous e-mail) checks NaN explicitly
if needed.

Best regards,
Yuya Watari
NTT Software Innovation Center
watari.yuya@gmail.com



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Include RELKIND_TOASTVALUE in get_relkind_objtype
Next
From: Fabien COELHO
Date:
Subject: Re: pgbench - refactor init functions with buffers