Postgres Pro
Downloads
Home   >   mailing lists

Re: PG compilation error with Visual Studio 2015/2017/2019 - Mailing list pgsql-hackers

From davinder singh
Subject Re: PG compilation error with Visual Studio 2015/2017/2019
Date
Msg-id CAHzhFSHudQRufGzH3KmjMxxQqTEPsewf-4Dck29fEuKw6QAkcw@mail.gmail.com
Whole thread Raw
In response to Re: PG compilation error with Visual Studio 2015/2017/2019  (Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>)
Responses Re: PG compilation error with Visual Studio 2015/2017/2019  (Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>)
List pgsql-hackers
Tree view


On Tue, Apr 7, 2020 at 8:30 PM Juan José Santamaría Flecha <juanjo.santamaria@gmail.com> wrote:

* The logic on "defined(_MSC_VER) && (_MSC_VER >= 1900)" is defined as "_WIN32_WINNT >= 0x0600" on other parts of the code. I would recommend using the later.
I think  "_WIN32_WINNT >= 0x0600" represents windows versions only and doesn't include any information about Visual Studio versions. So I am sticking to " defined(_MSC_VER) && (_MSC_VER >= 1900)".
I have resolved other comments. I have attached a new version of the patch.
--
Regards,
Davinder.
Attachment

pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: recovery_target_action=pause with confusing hint
Next
From: Amit Kapila
Date:
Subject: Re: pg_stat_statements issue with parallel maintenance (Was Re: WALusage calculation patch)