Hi Ajin,
Some review comments for patch v17-0001
======
Commit message
1.
Additionally, transactions containing WAL records (INTERNAL_SNAPSHOT,
COMMAND_ID, or INVALIDATION) that modify the historical snapshot
constructed during logical decoding are deemed unfilterable. This
is necessary because constructing a correct historical snapshot
for searching publication information requires processing these WAL record.
~
/these WAL record./these WAL records./
======
src/backend/replication/logical/reorderbuffer.c
ReorderBufferFilterByRelFileLocator:
2.
+ if (found)
+ {
+ rb->try_to_filter_change = entry->filterable;
+ return entry->filterable;
+ }
+
Bad indentation.
======
src/include/replication/reorderbuffer.h
3.
+extern bool ReorderBufferCanFilterChanges(ReorderBuffer *rb);
+
Why is this extern here? This function is not implemented in patch 0001.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
