Here are some review comments for latest patch v20240725-0002
======
doc/src/sgml/ref/create_publication.sgml
nitpick - tweak to the description of the example.
======
src/backend/parser/gram.y
preprocess_pub_all_objtype_list:
nitpick - typo "allbjects_list"
nitpick - reword function header
nitpick - /alltables/all_tables/
nitpick - /allsequences/all_sequences/
nitpick - I think code is safe as-is because makeNode internally does
palloc0, but OTOH adding Assert would be nicer just to remove any
doubts.
======
src/bin/psql/describe.c
1.
+ /* Print any publications */
+ if (pset.sversion >= 180000)
+ {
+ int tuples = 0;
No need to assign value 0 here, because this will be unconditionally
assigned before use anyway.
~~~~
2. describePublications
has_pubviaroot = (pset.sversion >= 130000);
+ has_pubsequence = (pset.sversion >= 18000);
That's a bug! Should be 180000, not 18000.
======
And, please see the attached diffs patch, which implements the
nitpicks mentioned above.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
