Re: Corrected documentation of data type for the logical replication message formats. - Mailing list pgsql-hackers

From Peter Smith
Subject Re: Corrected documentation of data type for the logical replication message formats.
Date
Msg-id CAHut+PtiPO4WJ_CH65aKv1A2V4-V-3jDuhKjDTwAEVcN_O4K0g@mail.gmail.com
Whole thread Raw
In response to Corrected documentation of data type for the logical replication message formats.  (vignesh C <vignesh21@gmail.com>)
Responses Re: Corrected documentation of data type for the logical replication message formats.  (Peter Smith <smithpb2250@gmail.com>)
Re: Corrected documentation of data type for the logical replication message formats.  (vignesh C <vignesh21@gmail.com>)
List pgsql-hackers
On Sun, May 9, 2021 at 10:38 PM vignesh C <vignesh21@gmail.com> wrote:
>
> Hi,
>
> For some of the logical replication messages the data type documented
> was not correct, especially for lsn and xid. For lsn actual datatype
> used is uint64 but is documented as int64, similarly for xid, datatype
> used is uint32 but documented as int32.
> Attached is a patch which has the fix for the same.
> Thoughts?

If you want to do this then there are more - e.g. Flags should be
Uint8 instead of Int8.

------
Kind Regards,
Peter Smith.
Fujitsu Australia



pgsql-hackers by date:

Previous
From: Yura Sokolov
Date:
Subject: Re: plan with result cache is very slow when work_mem is not enough
Next
From: "Euler Taveira"
Date:
Subject: Re: Corrected documentation of data type for the logical replication message formats.