Hi Ajin.
One comment for the patch set v18-0003..
======
1.
+$log_location = -s $node_publisher->logfile;
+$node_publisher->safe_psql('postgres', "DELETE FROM insert_only_table
WHERE id = 1");
+$node_publisher->wait_for_catchup('sub_all');
+
+$logfile = slurp_file($node_publisher->logfile, $log_location);
+ok($logfile =~ qr/Filtering DELETE/,
+ 'unpublished DELETE is filtered');
+
For this delete filter test, shouldn't there be another log file check
missing here which names the filtered relation? -- e.g. something like
+ok($logfile =~ qr/Filtering change for relation "insert_only_table"/,
+ 'delete for relation insert_only_table is filtered');
======
Kind Regards,
Peter Smith.
Fujitsu Australia
