Hi, here are some review comments for patch v7-0001.
======
src/backend/replication/logical/relation.c
logicalrep_report_missing_or_gen_attrs:
1.
+/*
+ * If attempting to replicate missing or generated columns, report an error.
+ * Prioritize 'missing' errors if both occur though the prioritization is
+ * random.
+ */
That part "though the prioritization is random" seems wrongly worded
because there is nothing random here.
I guess the intention was something like "This prioritization design
choice was arbitrary.", but TBH it may be better not to give any
reason at all.
======
src/test/subscription/t/011_generated.pl
2.
+# =============================================================================
+# The following test for expected error when attempting to replicate to a
+# generated subscriber column. Test the following combination
+# - regular -> generated
+# - generated -> generated
+# =============================================================================
+
Some plurals seemed wrong to me. e.g. "combination" etc.
SUGGESTION:
The following test verifies the expected error when replicating to a
generated subscriber column. Test the following combinations:
======
Kind Regards,
Peter Smith.
Fujitsu Australia
