[PATCH] nodeindexscan with reorder memory leak - Mailing list pgsql-hackers

From Aliaksandr Kalenik
Subject [PATCH] nodeindexscan with reorder memory leak
Date
Msg-id CAHqSB9gECMENBQmpbv5rvmT3HTaORmMK3Ukg73DsX5H7EJV7jw@mail.gmail.com
Whole thread Raw
Responses Re: [PATCH] nodeindexscan with reorder memory leak
Re: [PATCH] nodeindexscan with reorder memory leak
List pgsql-hackers
Hey!

I was investigating a leak reported in the PostGIS issues tracker [1] which led me to the Postgres side where the problem really is. The leak is reproducible with query from original ticket [1]:
WITH latitudes AS (	SELECT generate_series AS latitude	FROM generate_series(-90, 90, 0.1)
), longitudes AS (	SELECT generate_series AS longitude	FROM generate_series(-180, 180, 0.1)
), points AS (	SELECT ST_SetSRID(ST_Point(longitude, latitude), 4326)::geography AS geog	FROM latitudes	CROSS JOIN longitudes
)
SELECT	geog,	(		SELECT name		FROM ne_110m_admin_0_countries AS ne		ORDER BY p.geog <-> ne.geog		LIMIT 1	)
FROM points AS p
;
The leak is only noticeable when index scan with reorder happens as part of subquery plan which is explained by the fact that heap tuples cloned in reorderqueue_push are not freed during flush of reorder queue in ExecReScanIndex.

[1] https://trac.osgeo.org/postgis/ticket/4720
Attachment

pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: archive modules
Next
From: Peter Geoghegan
Date:
Subject: Re: Removing more vacuumlazy.c special cases, relfrozenxid optimizations