Re: [PATCH] nodeindexscan with reorder memory leak - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] nodeindexscan with reorder memory leak
Date
Msg-id 219144.1643558575@sss.pgh.pa.us
Whole thread Raw
In response to [PATCH] nodeindexscan with reorder memory leak  (Aliaksandr Kalenik <akalenik@kontur.io>)
List pgsql-hackers
Aliaksandr Kalenik <akalenik@kontur.io> writes:
> The leak is only noticeable when index scan with reorder happens as part of
> subquery plan which is explained by the fact that heap tuples cloned in
> reorderqueue_push are not freed during flush of reorder queue in
> ExecReScanIndex.

Hmm ... I see from the code coverage report[1] that that part of
ExecReScanIndexScan isn't even reached by our existing regression
tests.  Seems bad :-(

            regards, tom lane

[1] https://coverage.postgresql.org/src/backend/executor/nodeIndexscan.c.gcov.html#577



pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: pg_basebackup WAL streamer shutdown is bogus - leading to slow tests
Next
From: Tom Lane
Date:
Subject: Re: [PATCH] nodeindexscan with reorder memory leak