Hi Dave,
We realized that many of the changes we would need to make for supporting Greenplum would need to go where there is pg version checking throughout the code. This is because unlike PPAS which mostly adds additional features, Greenplum is based on postgres 8.3.
It looks like much of the version checking logic is repeated at points where the features are differentiated by postgres version.
It might make sense at this point to refactor the way that feature flagging is done to be a little bit more unified between server types and postgres versions so that we could for example have logic along the lines of:
feature_enablement = FeatureEnablement(postgres_flavor, postgres_version)
#...
if(feature_enablement.check_internal_triggers ):
# feature call here
and then in a feature enablement class, reference the various versions and flavors of postgres.
Any thoughts on this?
Thanks,
Tira and George
