Postgres Pro
Downloads
Home   >   mailing lists

[pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reportingstatus back to pgAdmin - Mailing list pgadmin-hackers

From Dave Page
Subject [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reportingstatus back to pgAdmin
Date
Msg-id CA+OCxoy=SeU3zCsV3yar0eqYAMMJPC_K9BpcYZ7uVgBRAhp9cQ@mail.gmail.com
Whole thread Raw
In response to [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reportingstatus back to pgAdmin  (Ashesh Vashi <ashesh.vashi@enterprisedb.com>)
Responses [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reportingstatus back to pgAdmin  (Fahar Abbas <fahar.abbas@enterprisedb.com>)
[pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin  (Fahar Abbas <fahar.abbas@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi

On Wed, Jan 11, 2017 at 12:28 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

On Wed, Jan 11, 2017 at 12:03 PM, Dave Page <dpage@pgadmin.org> wrote:

KeyError: u'end_time'

The status file contains:

{"start_time": "2017-01-11 06:27:20.939703 +0000", "pid": 49363, "exit_code": 0, "end_time": "2017-01-11 06:27:28.613456 +0000"}


Thanks for reviewing the patch.
Please find the updated patch.

Changes:
- Using now ValueError instead of json.JSONDecodeError, which is subclass of ValueError, to allow to it to work with 2.6+ python.
- Checking the existence of value in dict before accessing it.



That seems to work for me in a brief test on my Mac. :-)

Fahar; are you able to apply and test this patch on Windows and Linux, in server and desktop modes? Basically all the external processes should be tested - backup, restore & maintenance (vacuum) etc). I don't have any VMs available at the moment due to travel.


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment

pgadmin-hackers by date:

Previous
From: Ashesh Vashi
Date:
Subject: [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reportingstatus back to pgAdmin
Next
From: George Gelashvili
Date:
Subject: Re: [pgadmin-hackers] Driver Module