Re: brin_summarize_new_values error checking - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: brin_summarize_new_values error checking
Date
Msg-id CAHGQGwGAv3etCHf2L0+Xi1Jxjpygf2_bga=wWozAygKzfoBbhw@mail.gmail.com
Whole thread Raw
In response to brin_summarize_new_values error checking  (Jeff Janes <jeff.janes@gmail.com>)
Responses Re: brin_summarize_new_values error checking  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers
On Mon, Jan 25, 2016 at 4:03 PM, Jeff Janes <jeff.janes@gmail.com> wrote:
> In reviewing one of my patches[1], Fujii-san has pointed out that I
> didn't include checks for being in recovery, or for working on another
> backend's temporary index.
>
> I think that brin_summarize_new_values in 9.5.0 commits those same
> sins. In its case, I don't think those are critical, as they just
> result in getting less specific error messages that one might hope
> for, rather than something worse like a panic.
>
> But still, we might want to address them.

Agreed to add those checks. Also, I think we should document that
index maintenance functions cannot be executed during recovery.

Regards,

-- 
Fujii Masao



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Improve tab completion for REFRESH MATERIALIZED VIEW
Next
From: Fujii Masao
Date:
Subject: Re: log_checkpoint's "0 transaction log file(s) added" is extremely misleading