Re: brin_summarize_new_values error checking - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: brin_summarize_new_values error checking
Date
Msg-id CAHGQGwEPy8SZWJBpBaSPPLbLbKuOBKv35tLNctuWaqZTZ5ARPw@mail.gmail.com
Whole thread Raw
In response to Re: brin_summarize_new_values error checking  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: [HACKERS] brin_summarize_new_values error checking  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
On Wed, Jan 27, 2016 at 11:56 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
> On Mon, Jan 25, 2016 at 4:03 PM, Jeff Janes <jeff.janes@gmail.com> wrote:
>> In reviewing one of my patches[1], Fujii-san has pointed out that I
>> didn't include checks for being in recovery, or for working on another
>> backend's temporary index.
>>
>> I think that brin_summarize_new_values in 9.5.0 commits those same
>> sins. In its case, I don't think those are critical, as they just
>> result in getting less specific error messages that one might hope
>> for, rather than something worse like a panic.
>>
>> But still, we might want to address them.
>
> Agreed to add those checks.

Attached patch does this.

Regards,

--
Fujii Masao

Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold <
Next
From: Fujii Masao
Date:
Subject: Re: FATAL: could not send end-of-streaming message to primary: no COPY in progress