Re: GIN logging GIN_SEGMENT_UNMODIFIED actions? - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: GIN logging GIN_SEGMENT_UNMODIFIED actions?
Date
Msg-id CAHGQGwFTFScvvki9u_kNwiTLr0HeUzZ97g+mM277A3H=RTvyAQ@mail.gmail.com
Whole thread Raw
In response to Re: GIN logging GIN_SEGMENT_UNMODIFIED actions?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Thu, Sep 1, 2016 at 10:24 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Fujii Masao <masao.fujii@gmail.com> writes:
>> I applied your suggested changes into the patch. Patch attached.
>
> That looks pretty sane to me (but I just eyeballed it, didn't test).
>
> One further minor improvement would be to rearrange the
> XLOG_GIN_VACUUM_DATA_LEAF_PAGE case so that we don't bother calling
> XLogRecGetBlockData() if there's a full-page image.

Pushed the patch with this improvement. Thanks!

Regards,

-- 
Fujii Masao



pgsql-hackers by date:

Previous
From: Ashutosh Bapat
Date:
Subject: Re: Push down more full joins in postgres_fdw
Next
From: Heikki Linnakangas
Date:
Subject: Re: Random number generation, take two