Postgres Pro
Downloads
Home   >   mailing lists

Re: GIN logging GIN_SEGMENT_UNMODIFIED actions? - Mailing list pgsql-hackers

From Tom Lane
Subject Re: GIN logging GIN_SEGMENT_UNMODIFIED actions?
Date
Msg-id 21769.1472736288@sss.pgh.pa.us
Whole thread Raw
In response to Re: GIN logging GIN_SEGMENT_UNMODIFIED actions?  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: GIN logging GIN_SEGMENT_UNMODIFIED actions?  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers
Tree view 
Fujii Masao <masao.fujii@gmail.com> writes:
> I applied your suggested changes into the patch. Patch attached.

That looks pretty sane to me (but I just eyeballed it, didn't test).

One further minor improvement would be to rearrange the
XLOG_GIN_VACUUM_DATA_LEAF_PAGE case so that we don't bother calling
XLogRecGetBlockData() if there's a full-page image.
        regards, tom lane

pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: Logical decoding slots can go backwards when used from SQL, docs are wrong
Next
From: Michael Paquier
Date:
Subject: Re: Missing checks when malloc returns NULL...