Re: Log prefix missing for subscriber log messages received from publisher - Mailing list pgsql-hackers

On Tue, Jul 22, 2025 at 8:47 PM Álvaro Herrera <alvherre@kurilemu.de> wrote:
>
> On 2025-Jul-22, Fujii Masao wrote:
>
> > Is the issue caused by the use of _() in libpq-be-fe-helpers.h,
> > instead of using gettext_noop() in dblink.c? At least in my test
> > environment, the build error disappeared after applying
> > the following change:
> >
> > - errmsg_internal("%s: %.*s", _(prefix), len, message));
> > + errmsg_internal("%s: %.*s", prefix, len, message));
>
> Oh yeah, I should have remembered this -- see commit 213c959a294d.  Feel
> free to do away with the whole translation thing ... doesn't seem worth
> spending more time on it.

Yes! The attached patch removes the translation marker and the
gettext_noop() calls I recently added.

> We should still remove all gettext_noop() markers in contrib :-)

You mean to remove gettext_noop() also from basic_archive.c?

Regards,

--
Fujii Masao