Re: Log prefix missing for subscriber log messages received from publisher - Mailing list pgsql-hackers

From Álvaro Herrera
Subject Re: Log prefix missing for subscriber log messages received from publisher
Date
Msg-id 202507221147.sdg2rmhbqb5z@alvherre.pgsql
Whole thread Raw
In response to Re: Log prefix missing for subscriber log messages received from publisher  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: Log prefix missing for subscriber log messages received from publisher
List pgsql-hackers
On 2025-Jul-22, Fujii Masao wrote:

> Is the issue caused by the use of _() in libpq-be-fe-helpers.h,
> instead of using gettext_noop() in dblink.c? At least in my test
> environment, the build error disappeared after applying
> the following change:
> 
> - errmsg_internal("%s: %.*s", _(prefix), len, message));
> + errmsg_internal("%s: %.*s", prefix, len, message));

Oh yeah, I should have remembered this -- see commit 213c959a294d.  Feel
free to do away with the whole translation thing ... doesn't seem worth
spending more time on it.

We should still remove all gettext_noop() markers in contrib :-)

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/



pgsql-hackers by date:

Previous
From: Ashutosh Bapat
Date:
Subject: Re: SQL Property Graph Queries (SQL/PGQ)
Next
From: "Matheus Alcantara"
Date:
Subject: Re: Proposal: QUALIFY clause