Re: Log prefix missing for subscriber log messages received from publisher - Mailing list pgsql-hackers

On Tue, Jul 22, 2025 at 6:24 PM Álvaro Herrera <alvherre@kurilemu.de> wrote:
>
> On 2025-Jul-22, Álvaro Herrera wrote:
>
> > On 2025-07-22, Fujii Masao wrote:
> >
> > > The buildfarm member indri reported the following error, which seems related to
> > > the recent changes in dblink. I'll investigate this later.
> >
> > Ah yes — contrib doesn't have gettext support and macOS doesn't like
> > that. Maybe removing the gettext_noop calls in contrib is the easiest
> > solution. I think another option is to add -lintl to the link line but
> > that's probably messier, and without advantage since we still won't
> > have translation support.
>
> I wonder why doesn't contrib/basic_archive fail though.

Is the issue caused by the use of _() in libpq-be-fe-helpers.h,
instead of using gettext_noop() in dblink.c? At least in my test
environment, the build error disappeared after applying
the following change:

- errmsg_internal("%s: %.*s", _(prefix), len, message));
+ errmsg_internal("%s: %.*s", prefix, len, message));

Regards,

--
Fujii Masao