Postgres Pro
Downloads
Home   >   mailing lists

Possibly a comment typo in xlogrecord.h - Mailing list pgsql-hackers

From Rahila Syed
Subject Possibly a comment typo in xlogrecord.h
Date
Msg-id CAH2L28v34MnU37wQQLkwtZdBdXPaW6sN6kZMJFxRNGJfgwGyZw@mail.gmail.com
Whole thread Raw
Responses Re: Possibly a comment typo in xlogrecord.h  (Heikki Linnakangas <hlinnakangas@vmware.com>)
List pgsql-hackers
Tree view
Hello,

The comment before declaration of XLogRecordBlockHeader says 

>* 'data_length' is the length of the payload data associated with this,
> * and includes the possible full-page image, and rmgr-specific data. It

IIUC, data_length does not include associated full page image length. Attached patch changes the comment as follows:

- * and includes the possible full-page image, and rmgr-specific data. It
- * does not include the XLogRecordBlockHeader struct itself.
+ * and includes the rmgr-specific data. It does not include the possible
+ * full page image and XLogRecordBlockHeader struct itself.

Thank you,
Rahila Syed
Attachment

pgsql-hackers by date:

Previous
From: Mark Cave-Ayland
Date:
Subject: Re: Commitfest problems
Next
From: Marko Tiikkaja
Date:
Subject: Re: Commitfest problems