Re: Possibly a comment typo in xlogrecord.h - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Possibly a comment typo in xlogrecord.h
Date
Msg-id 54903736.7000406@vmware.com
Whole thread Raw
In response to Possibly a comment typo in xlogrecord.h  (Rahila Syed <rahilasyed90@gmail.com>)
List pgsql-hackers
On 12/16/2014 12:44 PM, Rahila Syed wrote:
> Hello,
>
> The comment before declaration of XLogRecordBlockHeader says
>
>> * 'data_length' is the length of the payload data associated with this,
>> * and includes the possible full-page image, and rmgr-specific data. It
>
> IIUC, data_length does not include associated full page image length.
> Attached patch changes the comment as follows:
>
> - * and includes the possible full-page image, and rmgr-specific data. It
> - * does not include the XLogRecordBlockHeader struct itself.
> + * and includes the rmgr-specific data. It does not include the possible
> + * full page image and XLogRecordBlockHeader struct itself.

Thanks, fixed! I also reworded the comment slightly, hopefully it's more 
readable now.

- Heikki




pgsql-hackers by date:

Previous
From: Claudio Freire
Date:
Subject: Re: Commitfest problems
Next
From: David Fetter
Date:
Subject: Re: Commitfest problems