Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Handle lack of DSM slots in parallel btree build. - Mailing list pgsql-committers

From Peter Geoghegan
Subject Re: pgsql: Handle lack of DSM slots in parallel btree build.
Date
Msg-id CAH2-Wzka0+vyX+iTTug3dKtUPvDDNNpVUY7nTF=MhAFgzTZ3uQ@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Handle lack of DSM slots in parallel btree build.  (Thomas Munro <thomas.munro@gmail.com>)
Responses Re: pgsql: Handle lack of DSM slots in parallel btree build.  (Peter Geoghegan <pg@bowt.ie>)
List pgsql-committers
Tree view 
On Tue, Feb 4, 2020 at 2:18 AM Thomas Munro <thomas.munro@gmail.com> wrote:
> Here is take 2.  I tested CI and CIC, and verified that workers are
> started or not depending on dsm_create() failure, using the attached
> fault injector patch.  (Fuzzing the regression tests repeatedly with
> that applied also revealed similar problems elsewhere in the tree,
> which I'll write about in a new thread.)

Can we reuse _bt_end_parallel() this time around? It would be easy to
add a "bool wait" argument to _bt_end_parallel(). All existing callers
would pass true, but when not using parallelism due to the new DSM
segment check we'd pass false.

-- 
Peter Geoghegan

pgsql-committers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: pgsql: Handle lack of DSM slots in parallel btree build.
Next
From: Peter Geoghegan
Date:
Subject: Re: pgsql: Handle lack of DSM slots in parallel btree build.