Re: cgit view availabel - Mailing list pgsql-hackers

From Victor Yegorov
Subject Re: cgit view availabel
Date
Msg-id CAGnEbojuqfTDCso+J0agTz3gYkHAz_7ELZEWgh3GqXrsqmR40w@mail.gmail.com
Whole thread Raw
In response to Re: cgit view availabel  (Magnus Hagander <magnus@hagander.net>)
Responses Re: cgit view availabel  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
вс, 17 янв. 2021 г. в 17:19, Magnus Hagander <magnus@hagander.net>:
> First thing I've noted:
>
>    https://git.postgresql.org/cgit/postgresql.git/commit/960869da0803427d14335bba24393f414b476e2c
>
> silently shows another commit.

Where did you get that URL from?

I've made it up manually, comparing cgit and gitweb links. 

 
And AFAICT, and URL like that in cgit shows the latest commit in the
repo, for the path that you entered (which in this case is the hash
put int he wrong place).

Yes, that's what I've noted too.


I guess we could capture a specific "looks like a hash" and redirect
that, assuming we would never ever have anything in a path or filename
in any of our repositories that looks like a hash. That seems like
maybe it's a bit of a broad assumption?

I thought maybe it's possible to rewrite requests in a form:

/cgit/*/commit/*

into

/cgit/*/commit/?id=&

?

--
Victor Yegorov

pgsql-hackers by date:

Previous
From: "Joel Jacobson"
Date:
Subject: evtfoid and evtowner missing in findoidjoins/README
Next
From: Surafel Temesgen
Date:
Subject: Re: WIP: System Versioned Temporal Table