Re: Deleting older versions in unique indexes to avoid page splits - Mailing list pgsql-hackers

From Victor Yegorov
Subject Re: Deleting older versions in unique indexes to avoid page splits
Date
Msg-id CAGnEbogkom5Hh+UGcu348kW+rnYfmOnauQ0T6Ao_YpdtKQECMw@mail.gmail.com
Whole thread Raw
In response to Re: Deleting older versions in unique indexes to avoid page splits  (Zhihong Yu <zyu@yugabyte.com>)
List pgsql-hackers
чт, 31 дек. 2020 г. в 20:01, Zhihong Yu <zyu@yugabyte.com>:
For v12-0001-Pass-down-logically-unchanged-index-hint.patch

+   if (hasexpression)
+       return false;
+
+   return true;

The above can be written as return !hasexpression;

To be honest, I prefer the way Peter has it in his patch.
Yes, it's possible to shorten this part. But readability is hurt — for current code I just read it, for the suggested change I need to think about it.

--
Victor Yegorov

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: crash recovery vs partially written WAL
Next
From: Pavel Stehule
Date:
Subject: Re: [HACKERS] [PATCH] Generic type subscripting