Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] CREATE/ALTER ROLE PASSWORD ('value' USING 'method') - Mailing list pgsql-hackers

From Rushabh Lathia
Subject Re: [HACKERS] CREATE/ALTER ROLE PASSWORD ('value' USING 'method')
Date
Msg-id CAGPqQf0FHZGx5ipBob1rdKzpV=syRAX2Px1tg=m440Eyu_We-Q@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] CREATE/ALTER ROLE PASSWORD ('value' USING 'method')  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [HACKERS] CREATE/ALTER ROLE PASSWORD ('value' USING 'method')  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
Tree view


On Wed, Mar 8, 2017 at 9:59 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
Michael Paquier <michael.paquier@gmail.com> writes:
> here is a separate thread dedicated to the following extension for
> CREATE/ALTER ROLE: PASSWORD ('value' USING 'method').

The parentheses seem weird ... do we really need those?

+1

I had quick glance to patch and it looks great.

One quick comments:

+            | PASSWORD '(' Sconst USING Sconst ')'
+                {
+                    $$ = makeDefElem("methodPassword",
+                                     (Node *)list_make2(makeString($3),
+                                                        makeString($5)),
+                                     @1);
+                }

methodPassword looks bit weird, can we change it to passwordMethod
or pwdEncryptMethod ?


                        regards, tom lane


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



--
Rushabh Lathia

pgsql-hackers by date:

Previous
From: "Tsunakawa, Takayuki"
Date:
Subject: Re: [HACKERS] some dblink refactoring
Next
From: Amit Langote
Date:
Subject: Re: [HACKERS] dropping partitioned tables without CASCADE