Re: run pgindent on a regular basis / scripted manner - Mailing list pgsql-hackers

From Jelte Fennema
Subject Re: run pgindent on a regular basis / scripted manner
Date
Msg-id CAGECzQTqoGHrePM_pwmhaM+J1XOygYjzFod4sf=PAt7J4A19Mw@mail.gmail.com
Whole thread Raw
In response to Re: run pgindent on a regular basis / scripted manner  (Bruce Momjian <bruce@momjian.us>)
Responses Re: run pgindent on a regular basis / scripted manner
List pgsql-hackers
> One issue on requiring patches to have run pgindent previously is
> actually the typedef list.  If someone adds a typedef in a commit, they
> will see different pgident output in the committed files, and perhaps
> others, and the new typedefs might only appear after the commit, causing
> later commits to not match.

I'm not sure I understand the issue you're pointing out. If someone
changes the typedef list, imho they want the formatting to change
because of that. So requiring an addition to the typedef list to also
commit reindentation to all files that this typedef indirectly impacts
seems pretty reasonable to me.



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Test failures of 100_bugs.pl
Next
From: "Takamichi Osumi (Fujitsu)"
Date:
Subject: RE: Time delayed LR (WAS Re: logical replication restrictions)