On Wed, May 25, 2016 at 6:42 AM, Thom Brown <thom@linux.com> wrote:
On 25 May 2016 at 02:00, Thom Brown <thom@linux.com> wrote: > On 25 May 2016 at 00:29, Thom Brown <thom@linux.com> wrote: >> On 24 May 2016 at 19:09, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: >>> >>> On Mon, May 23, 2016 at 6:35 PM, Murtuza Zabuawala >>> <murtuza.zabuawala@enterprisedb.com> wrote: >>>> >>>> Hi, >>>> >>>> PFA patch, which will fixes below mentioned issues, >>> >>> Committed. >> >> >> In the Create Table dialog, on the Advanced tab, the "Of type" drop-down >> lists tables and composite types, but those are supposed to just be >> composite types. >> >> Also, when using OF in CREATE TABLE, LIKE is no longer valid, so LIKE should >> be disabled when using OF. Also, there should probably be a way of setting >> options for the columns taken from the composite type. For example: >> >> CREATE TYPE inventory AS (product_id bigint, product_name text, weight >> numeric); >> >> CREATE TABLE stock OF inventory ( >> PRIMARY KEY (product_id), >> weight WITH OPTIONS DEFAULT 0 >> ); >> >> There's currently no way of doing this (neither the primary key, nor the >> default value for any columns). It should probably automatically populate >> the columns from the composite type on the columns tab. >> >> Also, could the generated SQL have an empty line between each statement? > > Another thing I've noticed is that, when adding columns, the "Is > primary key?" column is greyed out. Why not just make those > modifiable in that view rather than having to go into the details for > each column? > > When there's something that hasn't been set up correctly, like adding > variables for a column, but not actually selecting a variable, the SQL > pane, correctly, doesn't show an output, but the error message, > "Please provide input for variable." isn't enough to identify what > needs checking. Could the relevant tab and field/row be > highlighted/coloured in red/bold? This is more general, so doesn't > just apply to the create table dialog.
Last issue today:
When using "Of type", it's not valid to allow additional columns to be added, so those should be prevented. Thom