Re: [HACKERS] proposal psql \gdesc - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: [HACKERS] proposal psql \gdesc
Date
Msg-id CAFj8pRDrNVecPpWFTWsm+t3QKu8W1rzyjqZKeKbahkkEoHR70Q@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] proposal psql \gdesc  (Fabien COELHO <coelho@cri.ensmp.fr>)
Responses Re: [HACKERS] proposal psql \gdesc
Re: [HACKERS] proposal psql \gdesc
List pgsql-hackers
Hi

2017-06-04 10:47 GMT+02:00 Fabien COELHO <coelho@cri.ensmp.fr>:

Hello Brent,

Regarding the error message earlier

'No columns or command has no result',

it might be clearer with the slightly longer

'The result has no columns or the command has no result'.

I agree that a better phrasing may be possible.

I'm hesitating about this one because word "result" appears twice, but this is the underlying issue, maybe there is no result, or there is a result but it is empty... so somehow this might be unavoidable. On rereading it, I think that your sentence is better balance as the two cases have both a verb and a structured the same, so it seems better.

Another terser version could be: 'No or empty result' or 'Empty or no result', but maybe it is too terse.

I didn't read the patch though, just the email so that might not make sense in context.

Thanks for the suggestion!

new update - rebase, changed message

Regards

Pavel 



--
Fabien.

Attachment

pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: [HACKERS] BEFORE trigger can cause undetected partitionconstraint violation
Next
From: Amit Kapila
Date:
Subject: Re: [HACKERS] UPDATE of partition key