Postgres Pro
Downloads
Home   >   mailing lists

bugfix - plpgsql - statement counter is incremented 2x for FOR stmt - Mailing list pgsql-hackers

From Pavel Stehule
Subject bugfix - plpgsql - statement counter is incremented 2x for FOR stmt
Date
Msg-id CAFj8pRDXyQaJmpotNTQVc-t-WxdWZC35V2PnmwOaV1-taidFWA@mail.gmail.com
Whole thread Raw
Responses Re: bugfix - plpgsql - statement counter is incremented 2x for FOR stmt
List pgsql-hackers
Tree view
Hi

When I fixed one plpgsql_check issue, I found another plpgsql issue. Now we have field nstatements that hold a number of plpgsql statements in function. Unfortunately I made an error when I wrote this functionality and for FOR statements, this counter is incremented 2x. Higher number than a real number is better than a lesser number, but it can be a source of problems too (inside plpgsql_check I iterate over 0 .. nstatements stmtid, and due this bug I had a problem with missing statements).

Attached patch is pretty simple:

Regards

Pavel
Attachment

pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: adding wait_start column to pg_locks
Next
From: Tom Lane
Date:
Subject: Re: memory leak in auto_explain