Re: bugfix - plpgsql - statement counter is incremented 2x for FOR stmt - Mailing list pgsql-hackers

From Tom Lane
Subject Re: bugfix - plpgsql - statement counter is incremented 2x for FOR stmt
Date
Msg-id 3787233.1612294579@sss.pgh.pa.us
Whole thread Raw
In response to bugfix - plpgsql - statement counter is incremented 2x for FOR stmt  (Pavel Stehule <pavel.stehule@gmail.com>)
Responses Re: bugfix - plpgsql - statement counter is incremented 2x for FOR stmt
List pgsql-hackers
Pavel Stehule <pavel.stehule@gmail.com> writes:
> When I fixed one plpgsql_check issue, I found another plpgsql issue. Now we
> have field nstatements that hold a number of plpgsql statements in
> function. Unfortunately I made an error when I wrote this functionality and
> for FOR statements, this counter is incremented 2x. Higher number than a
> real number is better than a lesser number, but it can be a source of
> problems too (inside plpgsql_check I iterate over 0 .. nstatements stmtid,
> and due this bug I had a problem with missing statements).

> Attached patch is pretty simple:

Right, done.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: memory leak in auto_explain
Next
From: Pavel Stehule
Date:
Subject: Re: bugfix - plpgsql - statement counter is incremented 2x for FOR stmt