Re: bugfix - plpgsql - statement counter is incremented 2x for FOR stmt - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: bugfix - plpgsql - statement counter is incremented 2x for FOR stmt
Date
Msg-id CAFj8pRCHFT-nPc9Xmi-Ae9fv3cSvcxKwQ0YnnJ3GW5La0WZu0Q@mail.gmail.com
Whole thread Raw
In response to Re: bugfix - plpgsql - statement counter is incremented 2x for FOR stmt  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers


út 2. 2. 2021 v 20:36 odesílatel Tom Lane <tgl@sss.pgh.pa.us> napsal:
Pavel Stehule <pavel.stehule@gmail.com> writes:
> When I fixed one plpgsql_check issue, I found another plpgsql issue. Now we
> have field nstatements that hold a number of plpgsql statements in
> function. Unfortunately I made an error when I wrote this functionality and
> for FOR statements, this counter is incremented 2x. Higher number than a
> real number is better than a lesser number, but it can be a source of
> problems too (inside plpgsql_check I iterate over 0 .. nstatements stmtid,
> and due this bug I had a problem with missing statements).

> Attached patch is pretty simple:

Right, done.

Thank you for commit

Regards

Pavel


                        regards, tom lane

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: bugfix - plpgsql - statement counter is incremented 2x for FOR stmt
Next
From: "Joel Jacobson"
Date:
Subject: Re: Recording foreign key relationships for the system catalogs