Re: Refactor textToQualifiedNameList() - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: Refactor textToQualifiedNameList()
Date
Msg-id CAFj8pRDMhrMz+8Sz7g5Xv8+NBh-FO9c9=qWfgm_yHqem_GHr_w@mail.gmail.com
Whole thread Raw
In response to Re: Refactor textToQualifiedNameList()  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers


út 9. 10. 2018 v 13:20 odesílatel Michael Paquier <michael@paquier.xyz> napsal:
On Tue, Oct 09, 2018 at 10:47:48AM +0200, Pavel Stehule wrote:
> The difference on 10M calls is about 300ms - it is about 6%.

This number gives a good argument for rejecting this patch.  I am not
usually against code beautification, but that's a high price to pay for
just some refactoring.  On top of that, this potentially breaks
extension compilation.

ok

Regards

Pavel

--
Michael

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Refactor textToQualifiedNameList()
Next
From: Michael Paquier
Date:
Subject: Re: partition tree inspection functions