Re: Refactor textToQualifiedNameList() - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Refactor textToQualifiedNameList()
Date
Msg-id 20181009112046.GD1582@paquier.xyz
Whole thread Raw
In response to Re: Refactor textToQualifiedNameList()  (Pavel Stehule <pavel.stehule@gmail.com>)
Responses Re: Refactor textToQualifiedNameList()  (Pavel Stehule <pavel.stehule@gmail.com>)
Re: Refactor textToQualifiedNameList()  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
On Tue, Oct 09, 2018 at 10:47:48AM +0200, Pavel Stehule wrote:
> The difference on 10M calls is about 300ms - it is about 6%.

This number gives a good argument for rejecting this patch.  I am not
usually against code beautification, but that's a high price to pay for
just some refactoring.  On top of that, this potentially breaks
extension compilation.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: partition tree inspection functions
Next
From: Pavel Stehule
Date:
Subject: Re: Refactor textToQualifiedNameList()