Re: Review: check existency of table for -t option (pg_dump) when pattern... - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: Review: check existency of table for -t option (pg_dump) when pattern...
Date
Msg-id CAFj8pRCXPZc8xc4n_mv-AAaC5XVYN=pWmALrbuNim2PQdak0qw@mail.gmail.com
Whole thread Raw
In response to Review: check existency of table for -t option (pg_dump) when pattern...  (Teodor Sigaev <teodor@sigaev.ru>)
Responses Re: Review: check existency of table for -t option (pg_dump) when pattern...  (Teodor Sigaev <teodor@sigaev.ru>)
List pgsql-hackers
Hi

2015-09-11 17:59 GMT+02:00 Teodor Sigaev <teodor@sigaev.ru>:
https://commitfest.postgresql.org/6/201/

Patch looks good and is helpful in some usecases. I found and fix some typo (new version in attach), but patch shows some inconsistent output:
% pg_dump -t 'aaa*'  postgres
pg_dump: No matching tables were found
% pg_dump -t 'aaa*' --strict-names postgres
pg_dump: Table "aaa*" not found.

In second case error message is obviously worse.

There are two different situation - first message says "there are not any table for work", second says "There are not specific table(s) with specific names (mask)". I am thinking so this information is enough interesting for showing.

Can be changed to "No matching table(s) were found for filter "aaa*" " ?

Regards

Pavel
 
--
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
                                                   WWW: http://www.sigaev.ru/

pgsql-hackers by date:

Previous
From: Takashi Horikawa
Date:
Subject: Re: Partitioned checkpointing
Next
From: Sameer Thakur-2
Date:
Subject: Re: Support for N synchronous standby servers - take 2