Postgres Pro
Downloads
Home   >   mailing lists

Re: why pg_size_pretty is volatile? - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: why pg_size_pretty is volatile?
Date
Msg-id CAFj8pRCWN+Nbja9YYSc-8SzOPze5M1tsTJEH-=GWi=So7+gz6A@mail.gmail.com
Whole thread Raw
In response to Re: why pg_size_pretty is volatile?  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: why pg_size_pretty is volatile?  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers
Tree view


2016-01-26 2:00 GMT+01:00 Michael Paquier <michael.paquier@gmail.com>:
On Tue, Jan 26, 2016 at 5:35 AM, Pavel Stehule <pavel.stehule@gmail.com> wrote:
> Vitaly Burovoy pointed on bug in my patch - a pg_size_bytes was VOLATILE
> function. It is copy/paste bug - I used pg_size_pretty definition, so the
> question is: why pg_size_pretty is volatile? It should be immutable too.

+1. This function relies only on the input of its argument to generate a result.

attached patch

all tests passed

Regards

Pavel
 
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Vitaly Burovoy
Date:
Subject: Re: custom function for converting human readable sizes to bytes
Next
From: Joshua Berkus
Date:
Subject: Re: Releasing in September