Postgres Pro
Downloads
Home   >   mailing lists

Re: patch: make_timestamp function - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: patch: make_timestamp function
Date
Msg-id CAFj8pRBfRSrMjctgM33oqZW9LOSc9DWM_Z8FHZ_4=R58BnY1=g@mail.gmail.com
Whole thread Raw
In response to Re: patch: make_timestamp function  (Pavel Stehule <pavel.stehule@gmail.com>)
Responses Re: patch: make_timestamp function
List pgsql-hackers
Tree view
Hello


2013/12/17 Pavel Stehule <pavel.stehule@gmail.com>



2013/12/17 Tom Lane <tgl@sss.pgh.pa.us>
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> Yeah, I think a constructor should allow a text timezone.

Yes.  I think a numeric timezone parameter is about 99% useless,
and if you do happen to need that behavior you can just cast the
numeric to text no?

yes, it is possible. Although fully numeric API is much more consistent.


I was wrong - there are timezones with minutes like Iran = '1:30';

so int in hours is bad type - so only text is probably best

Pavel
 
Pavel
 

                        regards, tom lane


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Patch: show xid and xmin in pg_stat_activity and pg_stat_replication
Next
From: Dimitri Fontaine
Date:
Subject: Re: Extension Templates S03E11