Re: review: CHECK FUNCTION statement - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: review: CHECK FUNCTION statement
Date
Msg-id CAFj8pRBb1AhE--eePJs2ipkw9s3-FN5Cf0OCKhw+TobupKTaMA@mail.gmail.com
Whole thread Raw
In response to patch: CHECK FUNCTION statement  (Pavel Stehule <pavel.stehule@gmail.com>)
Responses Re: review: CHECK FUNCTION statement  (Pavel Stehule <pavel.stehule@gmail.com>)
List pgsql-hackers
2012/3/6 Alvaro Herrera <alvherre@commandprompt.com>:
>
> Excerpts from Pavel Stehule's message of mar mar 06 10:44:09 -0300 2012:
>>
>> 2012/3/6 Alvaro Herrera <alvherre@commandprompt.com>:
>> >
>> > Excerpts from Pavel Stehule's message of mar mar 06 03:43:06 -0300 2012:
>> >> Hello
>> >>
>> >> * I refreshed regress tests and appended tests for multi lines query
>> >> * There are enhanced checking of SELECT INTO statement
>> >> * I fixed showing details and hints
>> >
>> > Oh, I forgot to remove the do_tup_output_slot() function which I added
>> > in some previous version but is no longer necessary.  Also, there are
>> > two includes that I put separately in functioncmds.c that are only
>> > necessary for the CHECK FUNCTION stuff; those should be merged in with
>> > the other includes there.  (I was toying with the idea of moving all
>> > that code to a new file).
>> >
>>
>> I am not sure, what you did do. Can you remove this useless code, please?
>
> It's just a three line function that's not called anywhere.

ok

fixed patch

Pavel

>
> --
> Álvaro Herrera <alvherre@commandprompt.com>
> The PostgreSQL Company - Command Prompt, Inc.
> PostgreSQL Replication, Consulting, Custom Development, 24x7 support

Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: RFC: Making TRUNCATE more "MVCC-safe"
Next
From: Kohei KaiGai
Date:
Subject: Re: [v9.2] Add GUC sepgsql.client_label