po 7. 9. 2020 v 1:46 odesílatel Tom Lane <tgl@sss.pgh.pa.us> napsal:
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes: > Here is a new patch series version. > I have created a new internal function for converting integers to > numeric, to make the implementation a bit more elegant and compact.
I reviewed the 0002 patch, finding one bug (in int8_sum) and a few more calls of int8_numeric that could be converted. I think the attached updated version is committable, and I'd recommend going ahead with that regardless of the rest of this. I hadn't realized how many random calls of int8_numeric and int4_numeric we'd grown, but there are a lot, so this is nice cleanup.
This patch is a clean win.
+1
I continue to think that we can't commit 0003 in this form, because of the breakage that will ensure in stored views. As I said upthread, we should leave the existing SQL-exposed functions alone, invent new ones that return numeric, and alter the parser to translate EXTRACT constructs to the new functions. This approach would also provide an "out" for anyone who does complain about the performance cost --- they can just continue to use the old functions.
