[HACKERS] issue: record or row variable cannot be part of multiple-item INTO list - Mailing list pgsql-hackers

From Pavel Stehule
Subject [HACKERS] issue: record or row variable cannot be part of multiple-item INTO list
Date
Msg-id CAFj8pRB76FE2MVxJYPc1RvXmsf2upoTgoPCC9GsvSAssCM2APQ@mail.gmail.com
Whole thread Raw
Responses Re: [HACKERS] issue: record or row variable cannot be part of multiple-item INTO list  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi

I am working on migration large Oracle application to Postgres. When I started migration procedures with OUT parameters I found following limit 

"record or row variable cannot be part of multiple-item INTO list"

I checked code and it looks so this limit is not necessary for ROW types (what is enough for migration from Oracle, where REC is not available). 

Do you think so this limit is necessary for ROW types?

@@ -3368,19 +3368,7 @@ read_into_target(PLpgSQL_rec **rec, PLpgSQL_row **row, bool *strict)
    switch (tok)
    {
        case T_DATUM:
-           if (yylval.wdatum.datum->dtype == PLPGSQL_DTYPE_ROW)
-           {
-               check_assignable(yylval.wdatum.datum, yylloc);
-               *row = (PLpgSQL_row *) yylval.wdatum.datum;
-
-               if ((tok = yylex()) == ',')
-                   ereport(ERROR,
-                           (errcode(ERRCODE_SYNTAX_ERROR),
-                            errmsg("record or row variable cannot be part of multiple-item INTO list"),
-                            parser_errposition(yylloc)));
-               plpgsql_push_back_token(tok);
-           }
-           else if (yylval.wdatum.datum->dtype == PLPGSQL_DTYPE_REC)


Regards

Pavel

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] Valgrind & tests for `numeric`
Next
From: Dmitry Dolgov
Date:
Subject: Re: [HACKERS] logical decoding of two-phase transactions