Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] logical decoding of two-phase transactions - Mailing list pgsql-hackers

From Dmitry Dolgov
Subject Re: [HACKERS] logical decoding of two-phase transactions
Date
Msg-id CA+q6zcUJLTwammygSSp0=evX_Ns46b2JkvWu214jbM-15xc_MA@mail.gmail.com
Whole thread Raw
In response to [HACKERS] logical decoding of two-phase transactions  (Stas Kelvich <s.kelvich@postgrespro.ru>)
Responses Re: [HACKERS] logical decoding of two-phase transactions  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tree view
Hi

> On 4 April 2017 at 19:13, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> Other than that issue current patch still could not pass 'make check'
> test of contrib/test_decoding.

Just a note about this patch. Of course time flies by and it needs rebase,
but also there are few failing tests right now:

* one that was already mentioned by Masahiko
* one from `ddl`, where expected is:

```
SELECT slot_name, plugin, slot_type, active,
    NOT catalog_xmin IS NULL AS catalog_xmin_set,
    xmin IS NULl  AS data_xmin_not_set,
    pg_wal_lsn_diff(restart_lsn, '0/01000000') > 0 AS some_wal
FROM pg_replication_slots;
    slot_name    |    plugin     | slot_type | active | catalog_xmin_set | data_xmin_not_set | some_wal 
-----------------+---------------+-----------+--------+------------------+-------------------+----------
 regression_slot | test_decoding | logical   | f      | t                | t                 | t
(1 row)
```

but the result is:

```
SELECT slot_name, plugin, slot_type, active,
    NOT catalog_xmin IS NULL AS catalog_xmin_set,
    xmin IS NULl  AS data_xmin_not_set,
    pg_wal_lsn_diff(restart_lsn, '0/01000000') > 0 AS some_wal
FROM pg_replication_slots;
ERROR:  function pg_wal_lsn_diff(pg_lsn, unknown) does not exist
LINE 5:     pg_wal_lsn_diff(restart_lsn, '0/01000000') > 0 AS some_w...
            ^
HINT:  No function matches the given name and argument types. You might need to add explicit type casts.
```

pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: [HACKERS] issue: record or row variable cannot be part of multiple-item INTO list
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] issue: record or row variable cannot be part of multiple-item INTO list