Re: psql - add SHOW_ALL_RESULTS option - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: psql - add SHOW_ALL_RESULTS option
Date
Msg-id CAFj8pRAxur-Bz-EuD8ovz+ez_WNQecbuQb-yimXqT=83Eoa9jQ@mail.gmail.com
Whole thread Raw
In response to Re: psql - add SHOW_ALL_RESULTS option  (Fabien COELHO <coelho@cri.ensmp.fr>)
Responses Re: psql - add SHOW_ALL_RESULTS option
List pgsql-hackers


čt 22. 7. 2021 v 16:58 odesílatel Fabien COELHO <coelho@cri.ensmp.fr> napsal:

>> Ok. I noticed. The patch got significantly broken by the watch pager
>> commit. I also have to enhance the added tests (per Peter request).
>
> I wrote a test to check psql query cancel support.  I checked that it fails
> against the patch that was reverted.  Maybe this is useful.

Here is the updated version (v8? I'm not sure what the right count is),
which works for me and for "make check", including some tests added for
uncovered paths.

I included your tap test (thanks again!) with some more comments and
cleanup.

I tested manually for the pager feature, which mostly work, althoug
"pspg --stream" does not seem to expect two tables, or maybe there is a
way to switch between these that I have not found.

pspg doesn't support this feature. Theoretically it can be implementable (I am able to hold two datasets now), but without any help with synchronization I don't want to implement any more complex parsing. On the pspg side I am not able to detect what is the first result in the batch, what is the last result (without some hard heuristics - probably I can read some information from timestamps). And if you need two or more results in one terminal, then mode without pager is better.



--
Fabien.

pgsql-hackers by date:

Previous
From: Dean Rasheed
Date:
Subject: Re: Numeric x^y for negative x
Next
From: Tom Lane
Date:
Subject: Re: Followup Timestamp to timestamp with TZ conversion