Postgres Pro
Downloads
Home   >   mailing lists

Re: PostgreSQL vs SQL/XML Standards - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: PostgreSQL vs SQL/XML Standards
Date
Msg-id CAFj8pRAaGO5FX7bnP3E=mRssoK8y5T78x7jKy-vDiyS68L888Q@mail.gmail.com
Whole thread Raw
In response to Re: PostgreSQL vs SQL/XML Standards  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: PostgreSQL vs SQL/XML Standards
List pgsql-hackers
Tree view
Hi

pá 8. 3. 2019 v 19:44 odesílatel Alvaro Herrera <alvherre@2ndquadrant.com> napsal:
On 2019-Mar-08, Alvaro Herrera wrote:

> > Maybe we can call explicitly xmlFreeDoc instead xmlFreeNode
> >
> > some like
> >
> > if (cur_copy->type == XML_DOCUMENT_NODE)
> >   xmlFreeDoc((xmlDocPtr) cur_copy);
> > else
> >   xmlFreeNode(cur_copy);
> >
> > This looks most correct fix for me. What do you think?
>
> Seems like that should work, yeah ...

Something like this perhaps?  Less repetitive ...

I looking to code

        void        (*nodefree) (xmlNodePtr) = NULL;
        volatile xmlBufferPtr buf = NULL;

should not be "nodefree" volatile too?

Pavel
 

--
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: partitioned tables referenced by FKs
Next
From: Alvaro Herrera
Date:
Subject: Re: PostgreSQL vs SQL/XML Standards