Re: Re: csv format for psql - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: Re: csv format for psql
Date
Msg-id CAFj8pRAUdhyrrfJXi4oODy0bSaUg7YLG_DnVPf-=dgzE6nSkzQ@mail.gmail.com
Whole thread Raw
In response to Re: Re: csv format for psql  ("Daniel Verite" <daniel@manitou-mail.org>)
Responses Re: Re: csv format for psql  (Fabien COELHO <coelho@cri.ensmp.fr>)
List pgsql-hackers
Hi

2018-03-22 16:30 GMT+01:00 Daniel Verite <daniel@manitou-mail.org>:
        David Steele wrote:

> Do you know when you'll have an updated patch that addresses the minor
> issues brought up in review and the concern above?

Here's an update addressing the issues discussed:

- fieldsep and recordsep are used, no more fieldsep_csv
- the command line option is --csv without short option and is equivalent
 to -P format=csv -P fieldsep=','
- pset output formats are reordered alphabetically on display
- a couple more cases in the regression tests


I am sorry, I don't think so this design is correct. It introduce dependency on arguments order

# correct output
[pavel@nemesis postgresql]$ psql --csv -c "table foo" -F ';'
a;b;c
1;2;Hello
3;4;Nazdar

# error -F is ignored
[pavel@nemesis postgresql]$ psql -F ';' --csv -c "table foo"
a,b,c
1,2,Hello
3,4,Nazdar

Using \pset format csv means overwriting field sep every time - nobody uses |

I think so dependency on order of psql arguments is significant problem

Regards

Pavel



 

Best regards,
--
Daniel Vérité
PostgreSQL-powered mailer: http://www.manitou-mail.org
Twitter: @DanielVerite

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: PL/pgSQL nested CALL with transactions
Next
From: Teodor Sigaev
Date:
Subject: Re: Prefix operator for text and spgist support