Re: [HACKERS] Proposal : Parallel Merge Join - Mailing list pgsql-hackers

From Dilip Kumar
Subject Re: [HACKERS] Proposal : Parallel Merge Join
Date
Msg-id CAFiTN-vw52OefRPDnDf064q-N9bCBjPPxAS2SxiP18DG2Daiww@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Proposal : Parallel Merge Join  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: [HACKERS] Proposal : Parallel Merge Join  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
On Sat, Feb 25, 2017 at 11:29 AM, Amit Kapila <amit.kapila16@gmail.com> wrote:
> It seems you have forgotten to change in the below check:
>
> + if (innerpath != NULL &&
> + innerpath->parallel_safe &&
> + (cheapest_startup_inner == NULL ||
> + cheapest_startup_inner->parallel_safe == false ||
> + compare_path_costs(innerpath, cheapest_startup_inner,
> + STARTUP_COST) < 0))

Oops, Fixed.
>
>
> + /* Found a cheap (or even-cheaper) sorted parallel safer path */
>
> typo
> /safer/safe

Fixed
>
> Note - Change the patch status in CF app (to Needs Review) whenever
> you post a new patch.  I could see that your other patch also needs a
> similar update in CF app.

Will changes, Thanks.


-- 
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachment

pgsql-hackers by date:

Previous
From: Erik Rijkers
Date:
Subject: Re: [HACKERS] Logical replication existing data copy
Next
From: Simon Riggs
Date:
Subject: Re: [HACKERS] Allow pg_dumpall to work without pg_authid