Re: refactoring basebackup.c - Mailing list pgsql-hackers

From Dilip Kumar
Subject Re: refactoring basebackup.c
Date
Msg-id CAFiTN-uhg4iKA7FGWxaG9J8WD_LTx655+AUW3_KiK1=SakQy4A@mail.gmail.com
Whole thread Raw
In response to Re: refactoring basebackup.c  (tushar <tushar.ahuja@enterprisedb.com>)
Responses Re: refactoring basebackup.c  (Dilip Kumar <dilipbalaut@gmail.com>)
Re: refactoring basebackup.c  (tushar <tushar.ahuja@enterprisedb.com>)
List pgsql-hackers
On Mon, Jul 12, 2021 at 5:51 PM tushar <tushar.ahuja@enterprisedb.com> wrote:
>
> On 7/8/21 9:26 PM, Robert Haas wrote:
> > Here at last is a new version.
> Please refer this scenario ,where backup target using
> --server-compression is closing the server
> unexpectedly if we don't provide -no-manifest option
>
> [tushar@localhost bin]$ ./pg_basebackup --server-compression=gzip4  -t
> server:/tmp/data_1  -Xnone
> NOTICE:  WAL archiving is not enabled; you must ensure that all required
> WAL segments are copied through other means to complete the backup
> pg_basebackup: error: could not read COPY data: server closed the
> connection unexpectedly
>      This probably means the server terminated abnormally
>      before or while processing the request.
>

I think the problem is that bbsink_gzip_end_archive() is not
forwarding the end request to the next bbsink.  The attached patch so
fix it.


-- 
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

Attachment

pgsql-hackers by date:

Previous
From: Yugo NAGATA
Date:
Subject: pgbench: using prepared BEGIN statement in a pipeline could cause an error
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: 回复: Why is XLOG_FPI_FOR_HINT always need backups?