Re: DDL result is lost by CREATE DATABASE with WAL_LOG strategy - Mailing list pgsql-hackers

From Dilip Kumar
Subject Re: DDL result is lost by CREATE DATABASE with WAL_LOG strategy
Date
Msg-id CAFiTN-tEAaq6csi_6TB8sz=5ZV=XjhneUB0x5icfK8b3TLn+Xw@mail.gmail.com
Whole thread Raw
In response to Re: DDL result is lost by CREATE DATABASE with WAL_LOG strategy  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: DDL result is lost by CREATE DATABASE with WAL_LOG strategy
List pgsql-hackers
On Thu, Feb 16, 2023 at 5:37 AM Nathan Bossart <nathandbossart@gmail.com> wrote:
>
> On Wed, Feb 15, 2023 at 04:49:38AM +0000, Ryo Matsumura (Fujitsu) wrote:
> > The above is occured by the following call.
> > The argument 'permanent' of ReadBufferWithoutRelcache() is passed to
> > BufferAlloc() as 'relpersistence'.
> >
> > [src/backend/commands/]
> >  298         buf = ReadBufferWithoutRelcache(rnode, MAIN_FORKNUM, blkno,
> >  299                                         RBM_NORMAL, bstrategy, false);
>
> Indeed, setting that to true (as per the attached patch) seems to fix this.
> I don't see any reason this _shouldn't_ be true from what I've read so far.
> We're reading pg_class, which will probably never be UNLOGGED.

Yes, there is no reason to pass this as false, seems like this is
passed false by mistake.  And your patch fixes the issue.

-- 
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Katsuragi Yuta
Date:
Subject: Re: Is psSocketPoll doing the right thing?
Next
From: Michael Paquier
Date:
Subject: Re: Force testing of query jumbling code in TAP tests